Skip to content

chore: migrate repository formatting to rs fmt - #125

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/dogfood-rs-fmt
Jul 31, 2026
Merged

chore: migrate repository formatting to rs fmt#125
chenjiahan merged 1 commit into
mainfrom
chenjiahan/dogfood-rs-fmt

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

This PR migrates the repository's formatting scripts and staged-file tasks from the standalone Prettier CLI to rs fmt. Prettier options and ignore patterns now live under define.fmt, removing the separate configuration and ignore files. prettier-plugin-packagejson remains disabled with a TODO until rs fmt supports project-root plugin resolution.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 07b609d1-70a2-4c77-9e2a-cdfbc79f6dbe

📥 Commits

Reviewing files that changed from the base of the PR and between 0af3478 and 0087d5e.

📒 Files selected for processing (4)
  • .prettierignore
  • package.json
  • prettier.config.mjs
  • rstack.config.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 18ac809 into main Jul 31, 2026
3 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/dogfood-rs-fmt branch July 31, 2026 08:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0087d5e445

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"scripts": {
"build": "pnpm --filter './packages/**' build",
"check:format": "prettier . --check --experimental-cli",
"check:format": "rs fmt --check",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run formatting through the source CLI before builds

On a fresh checkout after pnpm install, both formatting scripts now resolve the workspace rs binary, whose packages/rstack/bin/rs.js:16 imports the gitignored dist/index.js; because installation no longer builds that package, pnpm check:format and pnpm format fail until contributors manually run a build. Use the repository source entry point (node scripts/rs.js fmt ...) as the existing prepare script does so these documented formatting commands remain usable independently of a build.

AGENTS.md reference: AGENTS.md:L19-L23

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant